Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support YAML values applier #67

Merged
merged 1 commit into from
Jan 30, 2024
Merged

*: support YAML values applier #67

merged 1 commit into from
Jan 30, 2024

Conversation

PugDeveloper
Copy link

@PugDeveloper PugDeveloper commented Jan 25, 2024 •
edited by fuweid
Loading

Closes: #25

fuweid
fuweid reviewed Jan 25, 2024
View reviewed changes
helmcli/release.go Outdated Show resolved Hide resolved
@PugDeveloper PugDeveloper force-pushed the swei/yamlvalueapplier branch 3 times, most recently from a79e0f3 to e790153 Compare January 29, 2024 18:05
fuweid
fuweid reviewed Jan 30, 2024
View reviewed changes
helmcli/release.go Outdated Show resolved Hide resolved
@PugDeveloper PugDeveloper force-pushed the swei/yamlvalueapplier branch 3 times, most recently from 3806059 to b77975e Compare January 30, 2024 02:21
@PugDeveloper PugDeveloper force-pushed the swei/yamlvalueapplier branch 3 times, most recently from afb6cb3 to b9f35cd Compare January 30, 2024 03:32
@PugDeveloper PugDeveloper force-pushed the swei/yamlvalueapplier branch from 2d291f3 to 8837a12 Compare January 30, 2024 03:50
@fuweid fuweid changed the title draft yamlvalueapplier *: support YAML values applier Jan 30, 2024
fuweid
fuweid approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuweid fuweid marked this pull request as ready for review January 30, 2024 03:53
@fuweid fuweid merged commit 663f4df into main Jan 30, 2024
4 checks passed
@fuweid fuweid deleted the swei/yamlvalueapplier branch January 30, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuweid fuweid fuweid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[helmcli] support YAMLValuesApplier helper function
2 participants
@PugDeveloper @fuweid